add `combine_aes()` function à la ggforce
Open
Nobody has claimed this yet.
internals :mag_right:
- Dominant language
- R
- Stars
- 7k
- Forks
- 2.1k
- Avg merge
- 59m
- Merged PRs (30d)
- 2
Description
Given, ggforce's filter inspiration #6774, another add that might be useful to the extender crowd could be combine_aes(), helpful in that it afford greater concision and also help better record which part of existing the defaults are the target of a change, as is done for example in GeomCircle's definition:
GeomCircle <- ggproto('GeomCircle', GeomShape,
default_aes = combine_aes(GeomShape$default_aes, aes(colour = 'black', fill = NA))
)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the combine_aes proposal in issue #6787, compare the ggforce inspiration in #6774, and inspect GeomCircle's use of GeomShape$default_aes. Clarify the intended behavior and compatibility with ggproto defaults; done means the API is defined and the GeomCircle-style example is supported.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- r
- Domain
- data-visualization
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100