Enable `filter` aesthetic à la ggforce
Open
Nobody has claimed this yet.
layers :chart_with_upwards_trend:
- Dominant language
- R
- Stars
- 7k
- Forks
- 2.1k
- Avg merge
- 59m
- Merged PRs (30d)
- 2
Description
From a discussion with Thomas, there was an idea to propagate the filter aesthetic that is found in the ggforce package to geoms in ggplot2. In ggforce, the filtering step is applied after the stat is computed in the Geom$setup_data() step, see e.g. here. We can consider making this a separate method so it will propagate to all extensions as well.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the ggforce implementation in R/mark_circle.R, especially the Geom$setup_data() step where filtering occurs. Then inspect how ggplot2 geoms and extensions handle post-stat data; done means defining and implementing a filter aesthetic that propagates to geoms and extensions consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- r
- Domain
- data-visualization
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100