Should `strip.placement = "outside"` be the default?
Nobody has claimed this yet.
- Dominant language
- R
- Stars
- 7k
- Forks
- 2.1k
- Avg merge
- 59m
- Merged PRs (30d)
- 2
Description
When you move the strips formed by faceting to the bottom, as in, e.g.:
ggplot(iris, aes(x = Sepal.Length, y = Petal.Length)) +
facet_wrap(~Species, strip.position = "bottom")
You end up with facet strips that sit in between the axis line and the x-axis labels. I could be entirely alone in this, but I find this ordering perplexing. Is there a particular reason the strips couldn't go to the outside of (beneath) the axis labels? It feels like having those as close to the axis line as possible would always be desirable, and having facet strips instead "interrupt" the connection between them feels off to me.
Presumably, the two rows (and just the relevant columns) in the gtable could get safely swapped if strip.position = "bottom" && x-axis label grobs exist in whatever row that is (11 I think?).
But, again, maybe I'm the only one who thinks the current ordering is strange! 😅
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the provided ggplot2 example with facet_wrap(~Species, strip.position = "bottom") and inspect the resulting gtable, especially the row containing x-axis labels and the proposed row 11. Compare the current strip and axis-label ordering, then determine whether changing the default to outside is appropriate and how relevant columns would be swapped. Done means a decided behavior backed by appropriate regression coverage.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- r
- Domain
- data-visualization
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100