Better way of handling parameters
Open
Nobody has claimed this yet.
feature
internals :mag_right:
- Dominant language
- R
- Stars
- 7k
- Forks
- 2.1k
- Avg merge
- 59m
- Merged PRs (30d)
- 2
Description
Currently the way we determine the parameters of a geom/stat is ugly. For example, the parameters of a geom are mostly imputed from draw_panel and draw_group, but some need to be listed explicitly in extra_args if they're used elsewhere (as in GeomTile$setup_data().
See also #1532 - na.rm also has to be special cased.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading how parameters are inferred from draw_panel and draw_group, then inspect GeomTile$setup_data() and the related discussion in #1532. The work is done when parameter handling no longer depends on scattered extra_args entries or a separate na.rm special case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- r
- Domain
- data-visualization
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100