tidymodels / tidymodels/workflows
consider relocating tests for `tune_args()` and `tunable()`
Open
Nobody has claimed this yet.
upkeep
- Dominant language
- R
- Stars
- 211
- Forks
- 26
- Avg merge
- 1h 58m
- Merged PRs (30d)
- 1
Description
As an additional comment... there are tests for
tune_args()andtunable()methods in extratests:
- https://github.com/tidymodels/extratests/blob/main/tests/testthat/test-tune_args.R
- https://github.com/tidymodels/extratests/blob/main/tests/testthat/test-tunable.R
do you think it's worth consolidating them with the tests here?
Originally posted by @hfrick in https://github.com/tidymodels/workflows/pull/193#pullrequestreview-1301528785
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare the existing tests in this repository with extratests/tests/testthat/test-tune_args.R and extratests/tests/testthat/test-tunable.R. Start by locating the corresponding local tests and reviewing the linked pull request discussion. Done means deciding whether the tests belong here and, if so, consolidating them without losing coverage.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- r
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100