tidymodels / tidymodels/rsample
Change order of classes for LOO
Open
Nobody has claimed this yet.
upkeep
- Dominant language
- R
- Stars
- 343
- Forks
- 67
- Avg merge
- 1h 9m
- Merged PRs (30d)
- 2
Description
This should be first the more specific class, then the more general class (and it could just be an anonymous function inside of loo_cv()). We'll need to check revdeps when changing this one.
https://github.com/tidymodels/rsample/blob/4357e119f621965dbcb4ed190c40ae8b7da7c0c8/R/loo.R#L35-L38
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading R/loo.R at lines 35-38 and the loo_cv() entry point. Confirm the class ordering change from the more general class first to the more specific class first, then check reverse dependencies for compatibility; done means the ordering is corrected without breaking affected reverse dependencies.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- r
- Domain
- data
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100