tidymodels / tidymodels/rsample

Main functions doesn't do any input checking on `data` argument

Open
#474 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature
Dominant language
R
Stars
343
Forks
67
Avg merge
1h 9m
Merged PRs (30d)
2

Description

sooo, there isn't much input checking for some of the main functions here in {rsample}, to the point of bootstraps(bootstraps) not returning an error 😬

bootstraps

library(rsample)

mat_cars <- as.matrix(mtcars)

bootstraps(mat_cars, times = 2)
#> # Bootstrap sampling 
#> # A tibble: 2 × 2
#>   splits          id        
#>   <list>          <chr>     
#> 1 <split [32/11]> Bootstrap1
#> 2 <split [32/11]> Bootstrap2

bootstraps(1:10, times = 2)
#> # Bootstrap sampling 
#> # A tibble: 0 × 2
#> # ℹ 2 variables: splits <list>, id <chr>

bootstraps(NULL)
#> # Bootstrap sampling 
#> # A tibble: 0 × 2
#> # ℹ 2 variables: splits <list>, id <chr>

bootstraps(lm(mpg ~ disp, data = mtcars))
#> # Bootstrap sampling 
#> # A tibble: 0 × 2
#> # ℹ 2 variables: splits <list>, id <chr>

vfold_cv

library(rsample)

mat_cars <- as.matrix(mtcars)

vfold_cv(mat_cars)
#> #  10-fold cross-validation 
#> # A tibble: 10 × 2
#>    splits         id    
#>    <list>         <chr> 
#>  1 <split [28/4]> Fold01
#>  2 <split [28/4]> Fold02
#>  3 <split [29/3]> Fold03
#>  4 <split [29/3]> Fold04
#>  5 <split [29/3]> Fold05
#>  6 <split [29/3]> Fold06
#>  7 <split [29/3]> Fold07
#>  8 <split [29/3]> Fold08
#>  9 <split [29/3]> Fold09
#> 10 <split [29/3]> Fold10

vfold_cv(1:10)
#> Error in if (v > max_v) {: argument is of length zero

vfold_cv(NULL)
#> Error in if (v > max_v) {: argument is of length zero

vfold_cv(lm(mpg ~ disp, data = mtcars))
#> Error in if (v > max_v) {: argument is of length zero

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the reported cases for the bootstraps and vfold_cv entry points with the invalid data values shown in the issue. Review how these functions currently handle those inputs and add input checking so invalid data produces an appropriate error rather than an empty result or an internal error; add tests for the examples.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
data
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.