tidymodels / tidymodels/extratests
melodie-swtich: Column order for `tune_results$.predictions` changed
Open
Nobody has claimed this yet.
upkeep
- Dominant language
- R
- Stars
- 23
- Forks
- 0
- Avg merge
- 3h 57m
- Merged PRs (30d)
- 1
Description
With https://github.com/tidymodels/tune/tree/melodie-switch:
The .predictions data frame of a tune_results object has a different column order now. It affects censored regression.
tests/testthat/test-survival-tune-grid.Rtests/testthat/test-survival-tune-bayes.R(first 3 tests)tests/testthat/test-survival-tune-sa.R
> expect_equal(
+ names(bayes_static_res$.predictions[[1]]),
+ c(".pred_time", ".row", "tree_depth", "event_time", ".config")
+ )
Error:
! names(bayes_static_res$.predictions[[1]]) (`actual`) not equal to c(".pred_time", ".row", "tree_depth", "event_time", ".config") (`expected`).
`actual`: ".pred_time" ".row" "event_time" "tree_depth" ".config"
`expected`: ".pred_time" ".row" "tree_depth" "event_time" ".config"
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the listed survival tests: tests/testthat/test-survival-tune-grid.R, test-survival-tune-bayes.R, and test-survival-tune-sa.R. Start with the first three Bayesian tests and compare the expected names of each .predictions data frame with the reported actual order. The work is done when the affected tests consistently pass with the intended column order.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- r
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100