tidymodels / tidymodels/extratests
Audit `skip()` with `minimum_version` requirements
Nobody has claimed this yet.
- Dominant language
- R
- Stars
- 23
- Forks
- 0
- Avg merge
- 3h 57m
- Merged PRs (30d)
- 1
Description
If we are past all the required versions on CRAN and RSPM, we don't really need those skip statements anymore, do we? Is there a case where it would install an older version and break again?
If we don't need the skip statements anymore, I suggest we remove them (even if they don't "hurt") so that we have one less thing to pay attention to when we look at the tests i.e. lowering the cognitive load 😄
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the repository's test skip() calls that specify minimum_version, then check whether the relevant CRAN and RSPM requirements can still install older versions. Confirm whether any supported installation could fail without the skips; done means removing obsolete skips or documenting why each must remain.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- r
- Domain
- testing-qa
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100