tidymodels / tidymodels/embed

use helper `recipes_argument_select()` in relevant steps

Open
#250 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

tidy-dev-day :nerd_face: upkeep
Dominant language
R
Stars
146
Forks
23
PR merge metrics
No merged PRs in 30d

Description

Look at the following PR for examples of how it should be done https://github.com/tidymodels/recipes/pull/1486.

the main thing to remember is that enquos() should be used.

Should be done to all steps with outcome arguments.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading tidymodels/recipes#1486 for the intended use of recipes_argument_select(), then inspect the embed step definitions for arguments named outcome. Update each relevant step consistently, using enquos() as noted, and verify that all steps with outcome arguments follow the same pattern.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
data
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.