thunderbird / thunderbird/thunderbird-notes

Markupsafe dependency hash doesn't match

Open
#26 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
44
Forks
16
Avg merge
2d 5h
Merged PRs (30d)
8

Description

Installing requirements leads to

Collecting markupsafe==1.0 (from -r requirements.txt (line 18))
  Downloading MarkupSafe-1.0.tar.gz (14 kB)
ERROR: THESE PACKAGES DO NOT MATCH THE HASHES FROM THE REQUIREMENTS FILE. If you have updated the package versions, please update the hashes. Otherwise, examine the package contents carefully; someone may have tampered with them.
    markupsafe==1.0 from https://files.pythonhosted.org/packages/4d/de/32d741db316d8fdb7680822dd37001ef7a448255de9699ab4bfcbdf4172b/MarkupSafe-1.0.tar.gz (from -r requirements.txt (line 18)):
        Expected sha256 a4ec1aff59b95a14b45eb2e23761a0179e98319da5a7eb76b56ea8cdc7b871c3
             Got        a6be69091dac236ea9c6bc7d012beab42010fa914c459791d627dad4910eb665

Updated hash does indeed match the one on PyPi
https://pypi.org/project/MarkupSafe/1.0/#copy-hash-modal-c08f00c4-fe6b-401f-a4a8-7cbe8b96bca4

Considering thunderbird-website uses markupsafe==2.1.3 we can probably just upgrade this right?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect requirements.txt at line 18 and compare the pinned MarkupSafe hash and version with the PyPI release referenced in the issue. Confirm whether updating the hash or upgrading MarkupSafe is compatible with this project, then verify that installing the requirements succeeds without a hash error.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
build-system
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.