thunderbird / thunderbird/thunderbird-android

Bump `jzlib` to version `1.1.3`

Open
#9,554 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type: dependency type: gradle
Dominant language
Kotlin
Stars
14k
Forks
2.8k
Avg merge
3d 3h
Merged PRs (30d)
57

Description

When updating jzlib to version 1.1.3, the RealImapConnectionTest.open() with COMPRESS=DEFLATE capability should enable compression test starts to fail:

RealImapConnectionTest > open() with COMPRESS=DEFLATE capability should enable compression FAILED
    java.net.SocketTimeoutException: Read timed out
        at java.base/sun.nio.ch.NioSocketImpl.timedRead(Unknown Source)
        at java.base/sun.nio.ch.NioSocketImpl.implRead(Unknown Source)
        at java.base/sun.nio.ch.NioSocketImpl.read(Unknown Source)
        at java.base/sun.nio.ch.NioSocketImpl$1.read(Unknown Source)
        at java.base/java.net.Socket$SocketInputStream.read(Unknown Source)
        at java.base/java.util.zip.InflaterInputStream.fill(Unknown Source)
        at java.base/java.util.zip.InflaterInputStream.read(Unknown Source)
        at java.base/java.io.BufferedInputStream.fill(Unknown Source)
        at java.base/java.io.BufferedInputStream.implRead(Unknown Source)
        at java.base/java.io.BufferedInputStream.read(Unknown Source)
        at com.fsck.k9.mail.filter.PeekableInputStream.peek(PeekableInputStream.kt:31)
        at com.fsck.k9.mail.store.imap.ImapResponseParser.readResponse(ImapResponseParser.java:45)
        at com.fsck.k9.mail.store.imap.ImapResponseParser.readResponse(ImapResponseParser.java:37)
        at com.fsck.k9.mail.store.imap.ImapResponseParser.readStatusResponse(ImapResponseParser.java:95)
        at com.fsck.k9.mail.store.imap.RealImapConnection.executeSimpleCommand(RealImapConnection.kt:747)
        at com.fsck.k9.mail.store.imap.RealImapConnection.executeSimpleCommand(RealImapConnection.kt:733)
        at com.fsck.k9.mail.store.imap.RealImapConnection.retrievePathDelimiter(RealImapConnection.kt:649)
        at com.fsck.k9.mail.store.imap.RealImapConnection.retrievePathDelimiterIfNecessary(RealImapConnection.kt:643)
        at com.fsck.k9.mail.store.imap.RealImapConnection.open(RealImapConnection.kt:106)
        at com.fsck.k9.mail.store.imap.RealImapConnectionTest.open() with COMPRESS=DEFLATE capability should enable compression(RealImapConnectionTest.kt:827)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the failure in RealImapConnectionTest.kt, specifically the open() with COMPRESS=DEFLATE capability test, and read the RealImapConnection.open() and ImapResponseParser.readResponse() paths shown in the trace. Update jzlib to 1.1.3 and determine why the test times out; done means the dependency is bumped and this compression test passes without a read timeout.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, kotlin
Domain
networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.