thunderbird / thunderbird/thunderbird-android
Convert XML screens to Compose
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 14k
- Forks
- 2.8k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 57
Description
The goal is to gradually replace XML based views / screens with composables. The view should be a 1 to 1 conversion with minimal changes to the design. If there are better alternatives in the design system they should be preferred .
In scope
Settings (global + per-account) and About
- Entrypoints:
com.fsck.k9.ui.settings.SettingsActivity(main settings hub)com.fsck.k9.ui.settings.general.GeneralSettingsActivitycom.fsck.k9.ui.settings.account.AccountSettingsActivity
- Fragments and related pieces:
com.fsck.k9.ui.settings.account.AccountSettingsFragmentcom.fsck.k9.ui.settings.account.AccountSettingsViewModelcom.fsck.k9.ui.settings.account.AccountSettingsDataStore+AccountSettingsDataStoreFactorycom.fsck.k9.ui.settings.account.AccountSelectionSpinnercom.fsck.k9.ui.settings.AboutFragmentcom.fsck.k9.ui.settings.SettingsActionItem,UrlActionItemcom.fsck.k9.ui.settings.account.OpenPgpAppSelectDialogcom.fsck.k9.ui.settings.account.AutocryptPreferEncryptDialogFragment,AutocryptPreferEncryptPreference
Accounts, Identities, and Folder management
- Accounts & identities:
com.fsck.k9.activity.AccountList(accounts overview)com.fsck.k9.ui.settings.account.ManageIdentities(legacy Java) andcom.fsck.k9.activity.EditIdentitycom.fsck.k9.activity.ChooseIdentity
- Folder management:
com.fsck.k9.ui.managefolders.ManageFoldersActivitycom.fsck.k9.ui.choosefolder.ChooseFolderActivity
Message source, changelog, push info, confirmations
com.fsck.k9.ui.messagesource.MessageSourceActivitycom.fsck.k9.ui.changelog.RecentChangesActivitycom.fsck.k9.ui.push.PushInfoActivitycom.fsck.k9.ui.notification.DeleteConfirmationActivity- Generic dialogs:
com.fsck.k9.fragment.ConfirmationDialogFragment,com.fsck.k9.view.HighlightDialogFragment
End-to-end encryption flows (Autocrypt)
com.fsck.k9.ui.endtoend.AutocryptKeyTransferActivityAutocryptKeyTransferPresenter,AutocryptKeyTransferViewModelAutocryptSetupMessageLiveEvent,AutocryptSetupTransferLiveEvent
Base UI and shared legacy views
com.fsck.k9.view.RecipientSelectView,ContactBadge,StatusIndicator,NonLockingScrollView,LinearViewAnimator,ToolableViewAnimator,ViewSwitcher,ThemeUtils, etc.
Out of scope
- Message Compose -> #8837
- Message List + Search -> #8838
- Message View + Attachments + Crypto status/details -> #8838
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the listed settings entry points and their related fragments, view models, and data stores to identify one self-contained XML screen. Compare each screen with the existing design system and preserve its current behavior and design while replacing its view with composables. The conversion is done when the selected in-scope screen and its related UI pieces no longer depend on the XML view implementation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, kotlin
- Domain
- mobile
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100