thunderbird / thunderbird/thunderbird-android
Add a confirmation action for permanently deleting emails
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 14k
- Forks
- 2.8k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 57
Description
Checklist
- I have used the search function to see if someone else has already submitted the same feature request.
- I will describe the problem with as much detail as possible.
- This issue only contains a request for one single feature, not multiple (related) features.
App version
6.800
Problem you are trying to solve
Prevent accidental deletion of emails in the "Trash", since after they're gone from there, they're gone for good.
One scenario when this can happen (as it just did to me):
You delete an email from inbox, then realize you still had to check something. You go to the trash to get the email back, and verify what you needed to. Then, when you're done with it, you may forget that it's already in the trash, and so you click the "Delete" button again; it's gone for good.
Suggested solution
Add something similar to the Outlook for Android implementation (default), where a confirmation message is shown before being able to delete an email from the "Trash" folder, and which specifies that the deletion will be permanent.
Screenshots / Drawings / Technical details
Add a new action to the already existing "Confirm actions" menu of the Interaction settings section; maybe something called "Delete (in Trash)".
I would assume that, by default, the confirmation message for these actions are generic, and so if this new action was to be implemented, having a personalized message (like done by Outlook devs) would be beneficial. Otherwise, a user who has multiple confirm actions enabled might confirm without thinking twice, which defeats the whole purpose of the confirmation feature.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Begin at the existing "Confirm actions" menu in Interaction settings and trace how the Trash folder's Delete action is handled. Check the current confirmation behavior and message; done means users can opt into a distinct permanent-delete confirmation with wording that identifies deletion as permanent.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, kotlin
- Domain
- mobile
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100