thunderbird / thunderbird/thunderbird-android
Ask for notification permission when enabling account notifications
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 14k
- Forks
- 2.8k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 57
Description
Currently the app is only asking for the notification permission during onboarding. But if the user doesn't grant the permission then, the app should ask again when the user enables notifications for an account (either when adding an additional account or via account settings).
We'll also have to handle the case where the user has denied the permission already and point them to the correct Android screen to reverse that decision.
Open question: What should the app do when it notices the notification permission has been revoked, but notifications are enabled inside the app?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the existing notification-permission request during onboarding, then inspect the account-addition and account-settings paths where notifications are enabled. Verify the Android flow for previously denied permissions and determine the expected behavior when system permission is revoked while in-app notifications remain enabled; completion depends on resolving that open question.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, kotlin
- Domain
- mobile
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100