thunderbird / thunderbird/thunderbird-android
Fix forwarded ViewModels in account setup and server validation
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 14k
- Forks
- 2.8k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 57
Description
Directly using the view model for account setup and server verification, and then passing it to the relevant view, is not recommended and should be replaced by a proper solution. This applies for all view models used for composable views.
At the moment this is suppressed for ServerValidationContent, ServerValidationScreen and AccountSetupScreen
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating ServerValidationContent, ServerValidationScreen, and AccountSetupScreen, then inspect the suppression covering their direct ViewModel forwarding. Trace how composable views receive these ViewModels and determine the proper replacement for all affected composable views. Done means the forwarding is replaced and the suppression is no longer needed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, kotlin
- Domain
- mobile
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100