thunderbird / thunderbird/thunderbird-android

Acount chip displaying in single acount mode (from unified inbox)

Open
#7,128 3 comments 1 reaction 1 assignee View on GitHub

@cketti is already working on this.

Since Oct 6, 2023.

Dominant language
Kotlin
Stars
14k
Forks
2.8k
Avg merge
3d 3h
Merged PRs (30d)
57

Description

Checklist
  • I have used the search function to see if someone else has already submitted the same bug report.
  • I will describe the problem with as much detail as possible.
App version

6.708

Where did you get the app from?

F-Droid

Android version

13

Device model

Pixel

Steps to reproduce
  1. Go to unified inbox
  2. click on a message
  3. See an account chip
Expected behavior

Not to see an account chip in single account mode

Actual behavior

I only have one account, so do not want to see account pills in my message view, however as of #7004 when opening a message from the unified inbox i get a account chip. This is inconsistent with other folder views where i do not see the chip as i have isSingleAccountMode
https://github.com/thundernest/k-9/blob/40d7db53f457dbcd382d3ee82cc07fbfb62d26fc/app/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt#L160
Should not always return true if isUnifiedInbox the logic needs to be a bit more complicated

Logs

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.