thunderbird / thunderbird/thunderbird-android
Skip invalid identities when importing settings
Open
Nobody has claimed this yet.
type: enhancement
- Dominant language
- Kotlin
- Stars
- 14k
- Forks
- 2.8k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 57
Description
When importing settings, skip identities that don't pass validation (e.g. because the email address doesn't pass validation). Only fail the import if there's no valid identity at all.
Add a log message with details on why an identity was considered invalid.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the settings import flow and its identity validation path; inspect how the import currently decides whether to fail. Done means invalid identities are skipped with reasons logged, while the import fails when no valid identity remains; cover both cases with tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, kotlin
- Domain
- mobile
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100