thunderbird / thunderbird/thunderbird-android

Don't crash on errors when loading the message list

Open
#5,408 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Kotlin
Stars
14k
Forks
2.8k
Avg merge
3d 3h
Merged PRs (30d)
57

Description

Crashes listed in the Google Play developer console suggest there are quite a few things that can go wrong when loading the message list. Currently MessageListLiveData doesn't deal with the case that loading the message list could fail with an error.

Fixing this involves at least the following steps:

  • Changing the UI code to display an error screen when the message list couldn't be loaded
  • Changing MessageListLiveData to catch exceptions and emit an error state if the message list couldn't be loaded

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with MessageListLiveData and the UI code that loads the message list; review how loading failures are currently handled. Done means the loader emits an error state when loading fails and the UI displays an error screen for that state.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
mobile
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.