thunderbird / thunderbird/thunderbird-android
Only hide attachment boxes for images that are actually displayed inline
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 14k
- Forks
- 2.8k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 57
Description
Currently we hide attachments with a Content-Disposition value of inline and a Content-Type value matching image/*. Most of the time these are inline images referenced in a text/html part. But we should check to make sure that's actually the case. Otherwise users won't be able to access attachments that are not referenced in the text/html part.
I noticed this happening on a mailing list where the text/html part was stripped. The text/plain part does reference the images using [cid:…]. But displaying images in text/plain parts is not something K-9 Mail supports right now.
See AttachmentInfoExtractor.extractAttachmentInfo().
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at AttachmentInfoExtractor.extractAttachmentInfo() and trace how inline image attachments are identified and hidden. Verify the behavior for HTML parts that reference images and for messages where the HTML part is missing or stripped; done means unreferenced attachments remain accessible, while actually displayed inline images stay hidden.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- kotlin
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100