thunderbird / thunderbird/thunderbird-android

Visible message actions options only partially working

Open
#4,922 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type: enhancement
Dominant language
Kotlin
Stars
14k
Forks
2.8k
Avg merge
3d 3h
Merged PRs (30d)
57

Description

Expected behaviour

The desired behaviour for me is that I can add the 'Move' action to action taskbars at the top of the screen by amending the options under 'Settings > General settings > Display > Visible message actions'
a. 'Taskbar actions' for visible message view reflects settings. (This worked in K-9 Mail version: 5.600)
b. There doesn't seem to be an option to change the available 'taskbar actions' when selecting messages in 'message list', so naively I would expect the settings to apply to this too.

Actual behaviour

I went to 'Settings > General settings > Display > Visible message actions' and selected 'Move' and deselected 'Delete'
a. Bug: Available 'taskbar actions' for visible message view is: Read/Unread, Next, Previous, Menu ('Move' not added but 'Deleted' was removed)
b. Enhancement: Available 'taskbar actions' when selecting messages in 'message list': Delete, Read/Unread, Archive, Next, Previous, Menu

Possible related issues

https://github.com/k9mail/k-9/issues/1341 (describes an issue which might be related)
https://github.com/k9mail/k-9/issues/1363 (describes similar enhancements but is now closed)

Steps to reproduce
  1. Go to 'Settings > General settings > Display > Visible message actions' and select 'Move' and deselect 'Delete'
  2. Go back to 'visible message view' or 'message list' and select a message
Environment

K-9 Mail version: 5.718 (Beta via Google Play store)
Android version: 9 (Lineage OS 16.0)
Account type (IMAP, POP3, WebDAV/Exchange): any
Please take some time to retrieve logs and attach them here: mot necessary
I exported the k9 settings file and can confirm that the keys 'messageViewMoveActionVisible and messageViewDeleteActionVisible are set to true and false respectively

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the settings change under Settings > General settings > Display > Visible message actions in both visible message view and message list selection. No source file or test is named; done means the configured Move and Delete actions are reflected correctly in the relevant taskbars, with the expected behavior clarified for message-list selection.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.