thunderbird / thunderbird/thunderbird-android
Investigate in which case `originalMessage.from` can be either null or empty on `TextQuoteCreator.prefixQuoteText`
Open
Nobody has claimed this yet.
status: help wanted
- Dominant language
- Kotlin
- Stars
- 14k
- Forks
- 2.8k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 57
Description
Currently, the static Address.toString(array) accepts a nullable Array and returns a nullable String. This can potentially cause a NullPointerException on TextQuoteCreator lines 34 and 36, as CoreResourceProvider.replyHeader expected a Non-nullable String.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading TextQuoteCreator around lines 34 and 36, then trace Address.toString(array) and CoreResourceProvider.replyHeader. Determine when originalMessage.from becomes null or empty and whether that can reach the non-null replyHeader value; the investigation is done when the failing case and expected handling are established.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- kotlin
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 48/100