thunderbird / thunderbird/services-ui
StandardFooter requires a global level vue-i18n instance
Nobody has claimed this yet.
- Dominant language
- Vue
- Stars
- 9
- Forks
- 1
- Avg merge
- 6h 58m
- Merged PRs (30d)
- 6
Description
Describe the bug
We are using $t() and t() interexchangeably when dealing with i18n. However, whenever we use $t(), it tries to find a global instance of the vue-i18n lib to be able to retrieve the translations.
This is a problem because for consumers of services-ui that don't have vue-i18n setup with the required keys, it would be impossible to override its default text.
Other components might also be affected!
To Reproduce
Steps to reproduce the behavior:
- Make a Vue app without vue-i18n setup (or use https://github.com/thunderbird/tbpro-add-on)
- Install
services-uiand try to useStandardFooter - See that the "Thunderbird is part of MZLA Technologies Corporation..." text doesn't show up
Expected behavior
We shouldn't require the keys to be defined on a per-project basis for these texts
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the StandardFooter component and inspect where it uses $t() or t(). Reproduce the issue in a Vue app without vue-i18n, such as the tbpro-add-on setup. Done means the Thunderbird corporate-text translation renders without requiring consumers to define the keys globally.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend, internationalization
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100