thunderbird / thunderbird/services-ui

Refactor button properties

Open
#171 0 comments 0 reactions 1 assignee View on GitHub

@devmount is already working on this.

Since Oct 6, 2025.

BREAKING enhancement
Dominant language
Vue
Stars
9
Forks
1
Avg merge
6h 58m
Merged PRs (30d)
6

Description

We currently use a type property for different button styles, which can be easily confused with the native button type prop.

Proposal:

  • Change the type prop to be exactly like the native button type
  • Change the variant prop (former type) to reflect the button flavor (primary, secondary, etc)
  • Add outline prop (former variant) as boolean if the button is rendered as outline only

This would be much more intuitive for devs.

Originally posted by @devmount in https://github.com/thunderbird/services-ui/issues/168#issuecomment-3362618340

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.