thunderbird / thunderbird/appointment
Disconnecting a calendar shouldn't delete a schedule
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 552
- Forks
- 29
- Avg merge
- 1d 6h
- Merged PRs (30d)
- 23
Description
Just had an experience where I:
- Downloaded my data (lucky me)
- Disconnected my CalDAV
- Went to Dashboard noticed the quicklink url was super long (another bug)
- Adjusted it and clicked saved
- Got the error message that "Schedule was not found"
I believe we technically require a schedule to have a calendar id, so in this case it was probably an intended path to delete any dangling calendar references. But that doesn't feel right. We should (if it's not already) make calendar_id nullable, and increase the "is active" condition on the schedule to include "if there's no calendar id selected."
It's also possible that this is just the database cascade triggering. Need to dig a little more into this at some point.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the reported sequence: download data, disconnect CalDAV, then edit and save the Dashboard quicklink. Trace how disconnecting handles the schedule's calendar_id and check whether a database cascade or the active-schedule condition causes “Schedule was not found”; done means the schedule remains usable after its calendar is disconnected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend, database
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100