thunderbird / thunderbird/appointment
Split real attachments and inline images for the mailer classes
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 552
- Forks
- 29
- Avg merge
- 1d 6h
- Merged PRs (30d)
- 23
Description
Right now we stick everything in a big attachments list and just reference it by an index. It was fine when there was like 2 inline images and maybe an invite.ics, but we're slowly adding more images to emails we should just split the inline images into a separate BaseMail list (or dict!).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate BaseMail and the current attachments list in the mailer classes, then trace how inline images and real attachments are referenced by index. Separate the two categories while preserving the existing mail output and invitation attachment behavior. Done means callers no longer need one mixed list to distinguish inline images from real attachments.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100