thunderbird / thunderbird/appointment

If public availability 500s the frontend will error out too

Open
#759 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug sentry
Dominant language
Python
Stars
552
Forks
29
Avg merge
1d 6h
Merged PRs (30d)
23

Description

Sentry error: https://thunderbird.sentry.io/issues/6075640605/?project=4505428280279040&query=is%3Aunresolved%20issue.priority%3A%5Bhigh%2C%20medium%5D&referrer=issue-stream&statsPeriod=14d&stream_index=0

We should check if errorDetail is falsey and show a generic error message instead of failing to error. Although I'm not sure if that's the actual error in the frontend code. So some investigation will be required!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Sentry report linked in the issue and trace the frontend path that handles public availability responses, focusing on cases where errorDetail is falsey. Confirm the actual failure and identify the existing generic-error behavior. Done means a failed public-availability request shows a generic error message instead of causing the frontend to error out, with the relevant test updated or added if one exists.

Written by the indexing model from the issue text.

Assessment

Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.