thunderbird / thunderbird/appointment
Check for empty data before extracting url on login
Open
Nobody has claimed this yet.
bug
- Dominant language
- Python
- Stars
- 552
- Forks
- 29
- Avg merge
- 1d 6h
- Merged PRs (30d)
- 23
Description
We currenyly do this, but we should check for data.value to exist before-hand.
const { url } = data.value;
This should fix login silently failing if the backend is down.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the login code containing const { url } = data.value; and inspect how the response is handled when the backend is unavailable. Reproduce a login attempt with no backend response, then verify that missing data.value is handled without silently failing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- authentication
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100