thunderbird / thunderbird/appointment

Raise stale test error for any tests that use deprecated routes

Open
#334 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

maintenance
Dominant language
Python
Stars
552
Forks
29
Avg merge
1d 6h
Merged PRs (30d)
23

Description

We have a handy deprecated flag for routes, right now it just logs the use of them. The intent is, they might still be used somewhere in the code, and we won't to remove it soon, but may not have the time in a specific ticket or timeframe to do the actual sweep.

However in prep we can start removing tests relating to those routes which should help us sniff out the remaining uses.

We basically just need to uncomment this line:
https://github.com/thunderbird/appointment/pull/329/commits/01a378c440adbba3fd769abaf1ad5c64378b868b#diff-a6a06a5597c188ae6a48e3740623436efa8e65a7e2f91f8f6b6c98cd0d182b5cR150

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect the referenced pull request commit and the diff around line 150 first. Uncomment the indicated line so tests using deprecated routes raise an error instead of only logging, then run the affected test suite and confirm those tests fail as intended.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing-qa
Issue type
Feature
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.