thpatch / thpatch/thcrap

[AoCF] Endings subtitles compatibility

Open
#92 1 comment 0 reactions 1 assignee View on GitHub

@brliron is already working on this.

Since Sep 9, 2018.

bug
Dominant language
C++
Stars
766
Forks
51
Avg merge
16d 14h
Merged PRs (30d)
1

Description

Currently, there is 2 problems with Endings and subtitles.

  • They are displayed at the same place as our text box (script_latin only)
  • Our pl parser just eats the subtitles.

2nd one will be fixed with the 2nd step of #70, but the 1st one also needs to be fixed.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.