[AoCF] Subtitles patching
Open
@brliron is already working on this.
Since Sep 5, 2018.
enhancement
in progress
- Dominant language
- C++
- Stars
- 766
- Forks
- 51
- Avg merge
- 16d 14h
- Merged PRs (30d)
- 1
Description
Allow patching the subtitles instead of the balloons, and allow to use 2 patch stacks, one for the balloons and another one for the subtitles.
Support for the win texts have been done in e9227a1594b9e29f066afc1fdf291135113fd0fd. But I would like to rewrite the entire PL parsing before adding subtitles support to story mode, because the current code is way too messy.
- Rewrite the core of the PL parsing
- Rewrite the th155 PL parsing
- Rewrite the th145 PL parsing
- Rewrite the th135 PL parsing
- Ensure the win subtitles still work with the new parsing
- Add subtitles support to story mode
- Add subtitles support to endings
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.