thpatch / thpatch/thcrap

Ending display bugs in 15.5

Open
#318 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
766
Forks
51
Avg merge
16d 14h
Merged PRs (30d)
1

Description

Reisen+Doremy and Mamizou+Mokou's endings in Antimony of Common Flowers terminate early.

Image

In case of the latter this is simply a transcription oversight, as the final line is for some reason split into its own paragraph when it should be part of the previous one.

https://github.com/user-attachments/assets/7d1eac60-d811-4adf-adc6-e041b4d760ce

However, in case of former, there doesn't seem be an oversight, and it just ends early for some reason...?

Image

Additionally, the pause special characters don't work properly in the translation. They do work in Hopeless Masquerade's and Urban Legend in Limbo's endings.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the Reisen+Doremy and Mamizou+Mokou endings in Antimony of Common Flowers and inspect how their translated text is split and rendered. Check the pause special characters against the working endings in Hopeless Masquerade and Urban Legend in Limbo; done means both endings reach their final lines and the pause characters display correctly.

Written by the indexing model from the issue text.

Assessment

Domain
content, localization
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.