thpatch / thpatch/thcrap

Bad kerning for in-battle Spell Card names in 13.5

Open
#317 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
766
Forks
51
Avg merge
16d 14h
Merged PRs (30d)
1

Description

Image

When you use a Spell Card name during a battle, their names are very squished, as the kerning is set wrong. You can see that the out-of-battle display in the game's deck mechanic menu works fine (minus the fact that long names will spill out, but such is reality of translating from a language as compact as Japanese)

...You can also see that it hates the „” quote marks as they seemingly just don't display in-battle at all.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue by displaying a translated Spell Card name during battle, then compare it with the deck mechanic menu display. Locate the in-battle name-rendering entry point and inspect its kerning and handling of „” quote marks; done means names have normal spacing and the quote marks display correctly in battle.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev, localization
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.