Fix ruby in SWR (with script_latin)
Open
Nobody has claimed this yet.
bug
- Dominant language
- C++
- Stars
- 766
- Forks
- 51
- Avg merge
- 16d 14h
- Merged PRs (30d)
- 1
Description
In script_latin, we change some font parameters to fix a 3rd line. This doesn't really work with ruby texts.
- it only displays the first word, anything after space doesn't show up
- the font is very small (probably because furigana is "balanced" around two lines, and with three it just gets really squished???)
- due to how high it shows up above the base text, anything on first line gets placed outside of rendering area
The 1st one is likely a script file parsing error and affects all patches, the 2 other ones are most likely about the dialog box layout changes in script_latin.
We should see if we can fix all 3 issues.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the ruby text issue in SWR with script_latin, then trace the script file parsing and the dialog box layout changes mentioned in the report. Check each of the three symptoms: text after spaces, furigana sizing across three lines, and first-line ruby placement outside the rendering area. Done means all three issues are fixed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- game-dev, internationalization
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100