[thcrap] Only display not being able to digitally sign once.
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 766
- Forks
- 51
- Avg merge
- 16d 14h
- Merged PRs (30d)
- 1
Description
11>d:\repos\thcrap\thcrap\thcrap\src\runconfig.cpp(361): warning C4834: discarding return value of function with 'nodiscard' attribute
Also, I feel like the warning about digital signing doesn't have to happen every project...
16>D:\Repos\thcrap\thcrap\Base.props(60,5): warning : D:\Repos\thcrap\thcrap\cert.pfx not found. Binaries won't be digitally signed, and thcrap won't be able to automatically update itself.
16>D:\Repos\thcrap\thcrap\Base.props(60,5): warning : Please see README.md for instructions on how to generate this file.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with thcrap/src/runconfig.cpp around line 361 and Base.props around line 60, then review the signing warnings shown in the issue. Determine how the nodiscard warning and repeated missing-cert.pfx warning are produced. Done means the reported warning behavior is corrected without losing the existing digital-signing guidance.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- build-system, security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100