thpatch / thpatch/thcrap-tsa

[MoF] Some replays end prematurely due to stage practice replay crash fix

Open
#46 6 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
JavaScript
Stars
27
Forks
15
Avg merge
15h 24m
Merged PRs (30d)
1

Description

With thcrap enabled replays did not progress through stages so it's only plays only one stage that we select in the menu.
https://user-images.githubusercontent.com/6560567/125425157-9a255f29-5e99-43d8-b9f9-689ab29dbc69.mp4
Here's how it works on a non-patched Steam version:
https://user-images.githubusercontent.com/6560567/125425552-208606b4-1060-49e8-8e23-0821b2339376.mp4

My configs and logs:
thcrap_log.zip
config.zip

Any luck to fix desync issue in this game as well?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing stage-practice replay with thcrap enabled and compare it with the non-patched Steam behavior shown in the linked videos. Inspect the attached thcrap log and config archives for the crash or desync; done means the replay progresses through all selected stages without ending prematurely.

Written by the indexing model from the issue text.

Assessment

Domain
game-dev
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.