aero: Implement as a plugin
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 27
- Forks
- 15
- Avg merge
- 15h 24m
- Merged PRs (30d)
- 1
Description
All this patch does is to change the parameter of all calls to DwmEnableComposition() from 0 to 1. This is exactly the sort of thing that can quickly be implemented using thcrap's function detour API and then automatically work for every build of every existing and possibly future Touhou game.
This needs a plug-in system (thpatch/thcrap#48) because Aero support should stay an optional feature. Apparently, there are problems with certain graphics drivers that lead to crashes when Aero is not disabled, which is probably why ZUN chose to do it in the first place.
Marking as minor though, since current versions of Windows don't have Aero anymore.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading thcrap/thcrap#48 and the thcrap function detour API, then locate all calls to DwmEnableComposition(). Done means Aero support is implemented as an optional plugin that changes those calls from 0 to 1 and can work across existing and future Touhou game builds.
Written by the indexing model from the issue text.
Assessment
- Domain
- operating-systems, tooling
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100