thpatch / thpatch/thcrap-tsa

≥TH14: Don't crash if the selected fullscreen resolution exceeds the maximum screen resolution

Open
#22 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

ZUN bug
Dominant language
JavaScript
Stars
27
Forks
15
Avg merge
15h 24m
Merged PRs (30d)
1

Description

This problem comes up very regularly in the #support channel on Discord, due to common laptop resolutions like 1366×768 or similar being smaller than the recommended 1280×960 resolution.

Could be solved in a number of ways that are better than crashing:
• Still running the game in 1280×960, but downscaling the rendered image to match the maximum resolution.
• Switching down to 960×720 or even 640×480 as necessary. (This is what windowed mode does.)
• Or just simply showing a clear error message.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing fullscreen launch on a 1366×768 or smaller display and trace how the selected 1280×960 resolution is handled. Compare the available approaches in the issue, then verify that an oversized fullscreen selection no longer crashes and instead scales, falls back, or reports a clear error.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.