thpatch / thpatch/thcrap-tsa

base_tsa: Allow "translation" of replay file names

Open
#2 1 comment 0 reactions 1 assignee View on GitHub

@32th-System is already working on this.

Since Jan 16, 2020.

enhancement
Dominant language
JavaScript
Stars
27
Forks
15
Avg merge
15h 24m
Merged PRs (30d)
1

Description

Modders usually want to change the game in more drastic ways than translators - adding new dialogue scripts with new text boxes, modifying danmaku scripts, or even changing parameters of shot types. All of these break existing replays recorded on the unpatched game. This would require players to closely keep track of the patches used for each replay.

By allowing patches to change the replay file name format used by the game, we easily eliminate this confusion.

The straightforward solution would require location of the replay format strings, and probably a new safe sprintf hack for each game. Automatically constructing such a new pattern from the patch stack might also be worth a thought.

Completion status (the list entries for all the ZUN games will be added as I go)

Additional notes:

  • so far I noticed that TH06 and TH07 will copy the file name into a buffer with a fixed size... of 512 bytes which is more than twice the size of a buffer with size MAX_PATH

  • th125 will concatenate the path to it's appdata directory with the scorefile name into a separate buffer on the stack.

  • A game being marked as (Tasofro) doesn't mean adding the replay and scorefile name stringlocs is something @brliron has to do. If anything, he might only have to help me out a little

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.