thoughtspot / thoughtspot/cs_tools

Does not handle periods in object names

Open
#265 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
2
Forks
7
PR merge metrics
No merged PRs in 30d

Description

First Stop
  • I have read and agreed to the ThoughtSpot LICENSE.
  • I understand that if I have a critical issue with ThoughtSpot, I should reach out to my designated Account Executive and Customer Success Manager instead of cs_tools.
Platform Configuration

Running the following command:
cs_tools tools git branches commit --tags version-controlled --metadata-types TABLE,VIEW,SQL_VIEW,MODEL,LIVEBOARD,ANSWER --comment "my commit comment" --org 123456789 --config my_config

Image
Description

Please see attached image for error. This data model is named "EAV 2.0 Data Model" and you can see that it separates the name of the data model on the period ".", and then assigns the second half of the name as the guid, then pushes the actual guid to the metadata-type field. This was happening on liveboards and data models that had names with periods in them.

This was fixed when I renamed all of our objects to no longer have periods in them, but this is obviously not the ideal solution here.

Considering adding a log file.

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with cs_tools tools git branches commit --tags version-controlled --metadata-types TABLE,VIEW,SQL_VIEW,MODEL,LIVEBOARD,ANSWER using an object named "EAV 2.0 Data Model". Trace how the command parses object names and metadata, then verify that periods remain part of the name while the actual GUID and metadata type are assigned correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.