thoughtbot / thoughtbot/dotfiles

`_load_settings` needs `set

Open
#634 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Shell
Stars
8.2k
Forks
1.8k
Avg merge
10d 14h
Merged PRs (30d)
1

Description

When bringing my dotfiles up-to-date including the Make _load_settings() more concise commit, I noticed my prompt turned into
2019-05-21_10-45
It turned out I had to setopt extendedglob as noted by the commit message. I ended up adding this configuration in my zshenv.local so by the time zshrc runs _load_settings, the glob can work correctly. Just wondering if it would make sense for setopt extendedglob to be in thoughtbot dotfiles (zshenv or zshrc?) instead of requiring custom config for _load_settings to work?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read the referenced “Make _load_settings() more concise” commit and inspect the zsh configuration around _load_settings, zshenv, and zshrc. Reproduce the prompt problem without extendedglob, then verify that the selected dotfile configuration lets _load_settings work without a custom zshenv.local setting.

Written by the indexing model from the issue text.

Assessment

Tech stack
shell, zsh
Domain
cli, tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.