thoughtbot / thoughtbot/administrate
Accessibility
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 6k
- Forks
- 1.1k
- PR merge metrics
- No merged PRs in 30d
Description
I’d love for Administrate to be as accessible, as possible. We’ve done some work in that area already: https://github.com/thoughtbot/administrate/pull/51, https://github.com/thoughtbot/administrate/pull/380, https://github.com/thoughtbot/administrate/pull/410, https://github.com/thoughtbot/administrate/pull/416.
But there is more work to be done. I’m going to use this issue to capture those:
- Links must have discernible text (21 violations)
- Target:
body > .app-container > .main-content > .search > .search__clear > a - Target:
body > .app-container > .main-content > .collection-data > tbody > tr:nth-of-type(1) > .cell-data.cell-data--email > .action-show.table__link-plain(repeat for each row in the data table)
- Target:
- Check a11y of linked table rows; fix the accessible label for table row links.
- Elements must have sufficient color contrast (76 violations)
- Target:
body > .app-container > .sidebar > .sidebar__list > li:nth-of-type(1) > .sidebar__link.sidebar__link--active(repeat for each blue link) - This is the blue link color we use
- Target:
- Swap
|in page titles, because screen readers read this as “vertical pipe.”
(I’m using the aXe Chrome extension to find these errors)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the unchecked accessibility findings and their listed CSS selectors, then inspect the related markup and the color definition in app/assets/stylesheets/administrate/library/_variables.scss. Use the aXe Chrome extension to verify that links have discernible text and table-row links have accessible labels; done means the reported violations are resolved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rails, ruby, scss
- Domain
- accessibility, frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100