thoughtbot / thoughtbot/administrate
Decouple Administrate from Kaminari
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 6k
- Forks
- 1.1k
- PR merge metrics
- No merged PRs in 30d
Description
We have several reports about problems with Kaminari, the gem we use for pagination. These are marked as https://github.com/thoughtbot/administrate/labels/pagination and include:
- https://github.com/thoughtbot/administrate/issues/1838
- https://github.com/thoughtbot/administrate/issues/2220
- https://github.com/thoughtbot/administrate/issues/2281
Last time I checked, Kaminari worked in a very "global" manner, making it difficult to enable/disable at will. It seemed very "all or nothing". Users have other pagination solutions in their apps, and loading Kaminari as well can cause issues. Also Kaminari overloads ActiveRecord, leading to more issues.
Ideally, we should isolate Kaminari and offer a way to opt out of it and use other gems, in a way similar to how we offer Pundit support as a separate add-on.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing how Administrate currently loads Kaminari and how Pundit support is isolated as a separate add-on. Done means Kaminari is isolated, users can opt out of it, and Administrate provides a documented path for using another pagination solution.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rails, ruby
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100