thheller / thheller/shadow-cljs
Cleanup handling of Closure Warnings
Nobody has claimed this yet.
- Dominant language
- Clojure
- Stars
- 2.4k
- Forks
- 192
- Avg merge
- 3h 11m
- Merged PRs (30d)
- 1
Description
Currently they are just logged once via shadow.build.closure/log-warnings but once cached they are gone. They are also kinda duplicated since JSInspector already runs into most of them and stores them in :js-warnings but that is never used. Don't know if :simple optimizations can generally find more or if parsing them via JSInspector already finds all.
Optimization warnings should be handled separately.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing shadow.build.closure/log-warnings and the JSInspector handling of :js-warnings, then compare what the :simple optimizations report. Determine how warnings behave across caching and how optimization warnings should be separated. Done means warnings are retained and handled without duplicate reporting, with optimization warnings treated independently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- clojure
- Domain
- compilers
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100