thheller / thheller/shadow-cljs

View as EDN breaks on large data structure

Open
#807 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Clojure
Stars
2.4k
Forks
192
Avg merge
3h 11m
Merged PRs (30d)
1

Description

Hi @thheller - thanks for your work on the Inspect feature. It is beautiful <3

Steps to Reproduce

  1. (tap> my-large-vector-of-maps-and-things) ;; ~6000 entities
  2. Inspect via shadow-cljs inspector
  3. Click on View as EDN
  4. Gets Stuck in "Loading..." state on the viewer
  5. Click on View as Browse and it loads the data again.

Potentially useful debugging data:
I see this error consistently in the console
Screenshot 2020-12-03 at 11 24 40

Further Info:

  1. View as EDN works fine with smaller vectors with maps in them, etc.

Please let me know if I can provide any further info or help with tracking this down!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue in the shadow-cljs inspector with a vector of roughly 6000 entities, then inspect the console error shown in the report. Compare the View as EDN and View as Browse paths; done means the EDN viewer finishes loading the large structure instead of remaining stuck on "Loading...".

Written by the indexing model from the issue text.

Assessment

Tech stack
clojure
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.