getWcaIdPage() has an off by 1 error
Open
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 15
- Forks
- 16
- PR merge metrics
- No merged PRs in 30d
Description
In sum of ranks, if you search by id for someone who's SOR placement is a multiple of 20, the page number will be 1 higher than it should be.
to recreate, go to https://statistics.worldcubeassociation.org/sum-of-ranks, search for someone who's rank is a multiple of 20 (e.g 2017SWOR01 who is no. 20) and press enter.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating getWcaIdPage() and reproduce the issue at the Sum of Ranks page with competitor 2017SWOR01, whose rank is 20. Check the page calculation for ranks that are exact multiples of 20; done means those searches return the correct page without the one-page offset.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- web-dev
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100