theupdateframework / theupdateframework/specification

Should the TUF update workflow eventually succeed even if non-volatile storage writes always fails?

Open
#131 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
405
Forks
59
Avg merge
3d 4h
Merged PRs (30d)
1

Description

In https://github.com/heartsucker/rust-tuf/pull/304, I'm extending rust-tuf to fail an update if writing to non-volatile storage fails. However, in https://github.com/heartsucker/rust-tuf/pull/304/files#r512292123, @wellsie1116 noticed an odd consequence to the update workflow, where even though the workflow fails on each storage, we're still updating our TUF trust database for each update attempt. So:

  • update attempt 1:
    • we trust 1.root.json
    • 5.1, we fetch a new root metadata 2.root.json, and set it as our trusted root.
    • we try and fail to write 1.root.json to non-volatile storage, and so we fail the update
  • update attempt 2:
    • 5.1, we try to fetch 3.root.json, but it doesn't exist
    • 5.2, we fetch timestamp.json, and set it as our trusted timestamp.
    • we try and fail to write timestamp.json to non-volatile storage, and so we fail the update.

And etc. I found this to be quite surprising, but I'm not sure if this is an actual problem. It sort of makes me wonder if it's really worthwhile failing a metadata update if we can't persist the metadata, and instead trying to signal to the user "we successfully updated the TUF metadata, but we couldn't persist the metadata because of ...". What do you all think?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read the linked rust-tuf pull request and the review discussion around comment r512292123 first. Trace the two described update attempts and determine whether failed non-volatile storage writes should fail the workflow or only report persistence failure; done requires an agreed behavior reflected in the specification.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
security
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.