theupdateframework / theupdateframework/python-tuf
ngtests: improve _assert* methods
Open
@MVrachev is already working on this.
Since Feb 23, 2022.
backlog
testing
- Dominant language
- Python
- Stars
- 1.7k
- Forks
- 304
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 17
Description
Description of issue or feature request:
Currently #1636 proposes three types of asserts for checking the state of local metadata:
_assert_files_exist_assert_content_equals_assert_version_equals
These still have some issues (see https://github.com/theupdateframework/python-tuf/pull/1636#discussion_r74079588, https://github.com/theupdateframework/python-tuf/pull/1636#pullrequestreview-794981714)
- non-trivial to pick which assert to use in which test case
_assert_content_equalscalls the private methodRepositorysimulator._fetch_metadata()to get the metadata content in bytes.
A smarter approach is needed, be it integrated in Repositorysimulator or not.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.