thephpleague / thephpleague/csv
Changing default settings for the package
Open
@nyamsprod is already working on this.
Since Sep 13, 2024.
documentation
hacktoberfest-accepted
version 10.0
- Dominant language
- PHP
- Stars
- 3.5k
- Forks
- 354
- Avg merge
- 9h 57m
- Merged PRs (30d)
- 5
Description
Feature Request
| Q | A |
|---|---|
| New Feature | no |
| BC Break | yes |
| version | 10.0 |
Proposal
We must revisit all default options of the package to match expected default for modern CSV handling. Changing any default from version 9 is automatically a BC break to be clearly documented.
- escape character must default to the empty string; previously was
\. - Reader::createFromPath must default to
ropen mode - Writer::createFromPath must default to
r+open mode
Changing the open mode will be done by removing the createFromPath method from the AbstractCSV class to implement it directly into the Reader and the Writer classes.
Should those classes be made final ❓
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.