themesberg / themesberg/flowbite
Closable data attribute for modals
Open
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 9.4k
- Forks
- 862
- PR merge metrics
- No merged PRs in 30d
Description
Hello!
The data-modal-backdrop="static" data attribute prevent the modal from closing when clicking outside of it.
Could you please add the data-modal-closable attribute for a Modal which will disable closing the modal both on hitting ESC and clicking on the backdrop.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the modal implementation and the existing handling for the data-modal-backdrop="static" attribute. Verify how backdrop clicks and ESC key presses are processed, then add coverage showing that data-modal-closable disables both closing paths.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, tailwindcss
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100